Changes HTML events config to return a list item instead of an ID. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Greg! Hope you've been well since elm-conf.
In my use, I've found that returning IDs in the event handlers requires an additional lookup to find the original data. When I click on an item, I want to have access to it immediately instead of having to look it up by ID.
This PR changes the type signature of
onMouseEnter,onMouseLeave, andonMouseClickfromString -> Maybe msg(whereStringis the item's ID) todata -> Maybe msg. It also changes the type signature ofonKeyDownto return an item.What do you think?
(cc/ @isaacsanders)