New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete deprecated method in jetty 9.4 #171

Merged

javabrett merged 1 commit into gretty-gradle-plugin:master from Park-Jongseok:delte-deprecated-method-in-jetty-9-4

Jul 8, 2020

Park-Jongseok commented Jul 7, 2020

Reference : Issue #2468 - Remove SoLinger.
Hello, I using jetty version 9.4 in gretty. when i started to server with command(./gradlew jettyRunWar), the message below being printed out.
The message is because the soLingerTime has been deprecated in Jetty 9.4 version.

WARN Ignoring deprecated socket close linger time

I'm not sure if this MR is correct way 😄 Thank you for providing a good plug-in.


          Delete deprecated method in jetty 9.4

af88ba8

boris-petrov requested review from boris-petrov, f4lco, henrik242 and javabrett

July 7, 2020 15:15

boris-petrov approved these changes

View reviewed changes

f4lco approved these changes

View reviewed changes

Collaborator

f4lco left a comment

Looks good to me 👍 Perhaps the commit message could include the "soLingerTime", such that it is easily searchable. Thank you very much!

henrik242 approved these changes

View reviewed changes

javabrett approved these changes

View reviewed changes

javabrett merged commit 81bf115 into gretty-gradle-plugin:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet