Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ukrainian #27

Merged
merged 4 commits into from
Nov 1, 2017
Merged

Ukrainian #27

merged 4 commits into from
Nov 1, 2017

Conversation

nykula
Copy link
Contributor

@nykula nykula commented Oct 31, 2017

References:

@coveralls
Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b9251e9 on makepost:master into 0431ac2 on greybax:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e0dff44 on makepost:master into 0431ac2 on greybax:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e0dff44 on makepost:master into 0431ac2 on greybax:master.

@greybax
Copy link
Owner

greybax commented Nov 1, 2017

Thank you @makepost for PR. Just one thing. I suppose ukrainian preset should be 'ua' instead of 'uk'. 'UK' is for United Kingdom.

@nykula
Copy link
Contributor Author

nykula commented Nov 1, 2017

Code for country and language can differ. ISO 639-1, used for example in Accept-Language header, defines Ukrainian as "uk". See https://docs.moodle.org/dev/Table_of_locales for more examples.

@greybax greybax merged commit a0188b5 into greybax:master Nov 1, 2017
@greybax
Copy link
Owner

greybax commented Nov 1, 2017

ok, make sense. Merged your changes. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants