Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing test cases for #23 and #24 and fix jasmine warnings caused by mixing async and done usage #25

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Add failing test cases for #23 and #24 and fix jasmine warnings caused by mixing async and done usage #25

merged 1 commit into from
Aug 2, 2021

Conversation

gribnoysup
Copy link
Owner

@gribnoysup gribnoysup commented Aug 1, 2021 •
edited
Loading

Fixes #22
Fixes #24

@gribnoysup gribnoysup force-pushed the add-tests-for-failing-cases branch 3 times, most recently from 2c860f1 to 5409d71 Compare August 2, 2021 08:44
@gribnoysup
Fix #22 and #24 and add a failing test case for #23
271c5d1 
- Do not mix `async` and `done` usage in jasmine env
- Stop polly instance on `test_skip`
- Add a test case for usage of global `Polly.register`
  (this currently fails on jest-circus)
- Update CI config to split test running in a better way
@gribnoysup gribnoysup force-pushed the add-tests-for-failing-cases branch from 5409d71 to 271c5d1 Compare August 2, 2021 08:48
@gribnoysup gribnoysup merged commit f3416fc into main Aug 2, 2021
@gribnoysup gribnoysup deleted the add-tests-for-failing-cases branch August 2, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop polly on test_skip events Triggers Jasmine deprecation
1 participant
@gribnoysup