-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sym storage not working #16
Conversation
src/LinearSolver.jl
Outdated
PardisoSolver(::Type{SymSparseMatrixCSR{Bi,Tv,Ti}}) where {Bi,Tv,Ti}= | ||
PardisoSolver(GridapPardiso.MTYPE_REAL_SYMMETRIC_INDEFINITE) | ||
|
||
PardisoSolver(op::AffineFEOperator) = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of implementing it only for AffineFEOperator
, I would do it for any FEOperator
like this:
PardisoSolver(op::FEOperator) = PardisoSolver(get_matrix_type(op))
And then, implement
function get_matrix_type(op::FEOperator)
@abstractmethod
end
function get_matrix_type(op::AffineFEOperator)
typeof(get_matrix(op))
end
These two last functions will be eventually moved to the Gridap repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit d88a2a0 solves this comment
hi @victorsndvg I have some comments to the PR. Minor things. I can merge the PR once they are fixed. |
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 78.66% 75.29% -3.38%
==========================================
Files 6 6
Lines 150 170 +20
==========================================
+ Hits 118 128 +10
- Misses 32 42 +10
Continue to review full report at Codecov.
|
fix #15