Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sym storage not working #16

Merged
merged 4 commits into from
Feb 6, 2020
Merged

Sym storage not working #16

merged 4 commits into from
Feb 6, 2020

Conversation

victorsndvg
Copy link
Contributor

fix #15

PardisoSolver(::Type{SymSparseMatrixCSR{Bi,Tv,Ti}}) where {Bi,Tv,Ti}=
PardisoSolver(GridapPardiso.MTYPE_REAL_SYMMETRIC_INDEFINITE)

PardisoSolver(op::AffineFEOperator) =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of implementing it only for AffineFEOperator, I would do it for any FEOperator like this:

PardisoSolver(op::FEOperator) = PardisoSolver(get_matrix_type(op))

And then, implement

function get_matrix_type(op::FEOperator)
  @abstractmethod
end

function get_matrix_type(op::AffineFEOperator)
  typeof(get_matrix(op))
end

These two last functions will be eventually moved to the Gridap repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit d88a2a0 solves this comment

@fverdugo
Copy link
Member

fverdugo commented Feb 6, 2020

hi @victorsndvg

I have some comments to the PR. Minor things. I can merge the PR once they are fixed.

@codecov-io
Copy link

codecov-io commented Feb 6, 2020

Codecov Report

Merging #16 into master will decrease coverage by 3.37%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   78.66%   75.29%   -3.38%     
==========================================
  Files           6        6              
  Lines         150      170      +20     
==========================================
+ Hits          118      128      +10     
- Misses         32       42      +10
Impacted Files Coverage Δ
src/GridapPardiso.jl 100% <ø> (ø) ⬆️
src/LinearSolver.jl 79.41% <50%> (-8.25%) ⬇️
src/load_mkl.jl 100% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859db5a...d88a2a0. Read the comment docs.

@fverdugo fverdugo merged commit a6571cc into master Feb 6, 2020
@fverdugo fverdugo deleted the sym_storage_not_working branch February 6, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEM driver with symmetric matrix storage not working
3 participants