Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of tentative changes required to upgrade GridapPardiso to Gridap 0.16 #28

Merged
merged 12 commits into from
Jul 27, 2021

Conversation

amartinhuertas
Copy link
Member

Hi @fverdugo,

find a tentative set of changes required to upgrade GridapPardiso to Gridap 0.16. Some comments:

  • I have upgraded the version of GridapPardiso to 0.5.0. Is this actually needed?
  • I have changed the compat version of Gridap to 0.15, 0.16, although I only tried with 0.16.
  • I explicitly added some function definition stataments here. I think these are no longer available in SparseMatricesCSR (perhaps with another name?) but required by GridapPardiso.

Thanks!
@amartinhuertas

@amartinhuertas amartinhuertas requested a review from fverdugo July 25, 2021 09:13
@fverdugo
Copy link
Member

CI is not running since it is still Travis-based...

@amartinhuertas
Copy link
Member Author

CI is not running since it is still Travis-based...

Ok, I will do it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.23%. Comparing base (cb369e1) to head (1c53fe9).
Report is 46 commits behind head on master.

Files with missing lines Patch % Lines
src/GridapPardiso.jl 58.33% 5 Missing ⚠️
src/LinearSolver.jl 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   77.22%   75.23%   -1.99%     
==========================================
  Files           6        6              
  Lines         202      210       +8     
==========================================
+ Hits          156      158       +2     
- Misses         46       52       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amartinhuertas
Copy link
Member Author

CI is not running since it is still Travis-based...

Ok, done. It took me more time than expected ... not easy to set up + Pardiso MKL in Github actions.

You can proceed with your code review.

Thanks!

@fverdugo fverdugo merged commit e1ccca8 into master Jul 27, 2021
@fverdugo fverdugo deleted the gridap_0.16 branch July 27, 2021 05:43
@amartinhuertas
Copy link
Member Author

Can we release the new version of GridapPardiso ?

@fverdugo
Copy link
Member

Yes sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants