-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bunch of tentative changes required to upgrade GridapPardiso to Gridap 0.16 #28
Conversation
GridapPardiso to Gridap 0.16
CI is not running since it is still Travis-based... |
Ok, I will do it. |
Added ci.yml (to be debugged)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 77.22% 75.23% -1.99%
==========================================
Files 6 6
Lines 202 210 +8
==========================================
+ Hits 156 158 +2
- Misses 46 52 +6 ☔ View full report in Codecov by Sentry. |
Ok, done. It took me more time than expected ... not easy to set up + Pardiso MKL in Github actions. You can proceed with your code review. Thanks! |
Can we release the new version of |
Yes sure! |
Hi @fverdugo,
find a tentative set of changes required to upgrade GridapPardiso to Gridap 0.16. Some comments:
0.5.0
. Is this actually needed?SparseMatricesCSR
(perhaps with another name?) but required byGridapPardiso
.Thanks!
@amartinhuertas