Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverted #1047 (updating styles) #1070

Merged
merged 3 commits into from
Nov 26, 2019
Merged

reverted #1047 (updating styles) #1070

merged 3 commits into from
Nov 26, 2019

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Nov 26, 2019 •
edited
Loading

Description

as it is causing cellheight() to fail (#1068) which is worse and more common than missing animation.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

reverted #1047 (updating styles)
65accb4 
as it is causing cellheight() to fail (#1068) which is worse and more common than missing animation.
@coveralls
Copy link

coveralls commented Nov 26, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 66.52% when pulling 31f35ef on adumesny:develop into 2631f71 on gridstack:develop.

@adumesny adumesny merged commit 66a2549 into gridstack:develop Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adumesny @coveralls