The .UHF file is now written if the molecule has a uhf larger than 0
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Schöps <[email protected]>
|
If we want it to be like this, we should do the same with the |
|
But is this something that would make sense to do, or were these files necessary for something? |
They are definitely helpful and necessary for the case that |
Signed-off-by: Jonathan Schöps <[email protected]>
marcelmbn
added
the
data-processing
Signed-off-by: Jonathan Schöps <[email protected]>
marcelmbn
requested changes
Nov 18, 2024
Signed-off-by: Jonathan Schöps <[email protected]>
marcelmbn
approved these changes
Nov 18, 2024
marcelmbn
added a commit
that referenced
this pull request
Nov 18, 2024
* Update Docs (#72) * update docs, co-workers, pyproject.toml, remove typos Signed-off-by: Marcel Müller <[email protected]> * update CHANGELOG, make case more consistent Signed-off-by: Marcel Müller <[email protected]> * update mindlessgen.toml Signed-off-by: Marcel Müller <[email protected]> * align defaults Signed-off-by: Marcel Müller <[email protected]> * update reference default value Signed-off-by: Marcel Müller <[email protected]> * update tests Signed-off-by: Marcel Müller <[email protected]> * correct inconsistent boolean Signed-off-by: Marcel Müller <[email protected]> --------- Signed-off-by: Marcel Müller <[email protected]> * Fix random number generation by removing legacy random number generation (#78) * fix random number generation by incorporating default_rng Signed-off-by: Marcel Müller <[email protected]> * update CHANGELOG.md Signed-off-by: Marcel Müller <[email protected]> --------- Signed-off-by: Marcel Müller <[email protected]> * Remove deprecated tests that are not strictly true (#79) * remove deprecated tests Signed-off-by: Marcel Müller <[email protected]> * remove random numpy seed as it's pointless now Signed-off-by: Marcel Müller <[email protected]> --------- Signed-off-by: Marcel Müller <[email protected]> * A fixed molecular charge for the molecule generation. (#73) * A new function to set a fixed charge value Signed-off-by: Jonathan Schöps <[email protected]> * latest changes to the fixed charge method Signed-off-by: Jonathan Schöps <[email protected]> * Fixed charge and element composition works test have to be added Signed-off-by: Jonathan Schöps <[email protected]> * More modular fixed charge routine Signed-off-by: Jonathan Schöps <[email protected]> * complete fixed charge routine Signed-off-by: Jonathan Schöps <[email protected]> * Removed an unnessesary import Signed-off-by: Jonathan Schöps <[email protected]> * more convenient function name Signed-off-by: Jonathan Schöps <[email protected]> * Worked in the suggested changes Signed-off-by: Jonathan Schöps <[email protected]> * Added a changelog entry Signed-off-by: Jonathan Schöps <[email protected]> * Changes a bug with an array type Signed-off-by: Jonathan Schöps <[email protected]> * removed left over print statements Signed-off-by: Jonathan Schöps <[email protected]> * Implemented requested changes Signed-off-by: Jonathan Schöps <[email protected]> * Added a new test to raise a ValueError Signed-off-by: Jonathan Schöps <[email protected]> --------- Signed-off-by: Jonathan Schöps <[email protected]> * `atlist` to `ati` and back conversion (#81) * implement atlist to ati conversion Signed-off-by: Marcel Müller <[email protected]> * add conversion test Signed-off-by: Marcel Müller <[email protected]> --------- Signed-off-by: Marcel Müller <[email protected]> * Bug fix were uhf was always 0 if a fixed charge were given (#80) * bug fix were uhf was always 0 if a fixed charge were given Signed-off-by: Jonathan Schöps <[email protected]> * updated a test for the right uhf Signed-off-by: Jonathan Schöps <[email protected]> * get rid of redundant code within set_random_charge Signed-off-by: Jonathan Schöps <[email protected]> * using atlist as a variable in misscellaneous Signed-off-by: Jonathan Schöps <[email protected]> --------- Signed-off-by: Jonathan Schöps <[email protected]> * adapt CODEOWNERS to commit history (#82) Signed-off-by: Marcel Müller <[email protected]> * The `.UHF` file is now written if the molecule has a uhf larger than 0 (#74) * The .UHF file is now written if the molecule has a uhf larger than 0 Signed-off-by: Jonathan Schöps <[email protected]> * Writes the .CHRG file if the charge is larger than 0 Signed-off-by: Jonathan Schöps <[email protected]> * charge and uhf can be None Signed-off-by: Jonathan Schöps <[email protected]> * Negative charge is now written aswell Signed-off-by: Jonathan Schöps <[email protected]> --------- Signed-off-by: Jonathan Schöps <[email protected]> * update CHANGELOG Signed-off-by: Marcel Müller <[email protected]> --------- Signed-off-by: Marcel Müller <[email protected]> Signed-off-by: Jonathan Schöps <[email protected]> Co-authored-by: Jonathan Schöps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.UHFfile is now only written if the molecule hasuhf > 0. This should make it more convenient to useMindlessGentogether withg-xTB.