Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning issues #165

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Fix code scanning issues #165

merged 7 commits into from
Sep 16, 2024

Conversation

marvinfriede
Copy link
Member

No description provided.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 84.38819% with 37 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (e999f14) to head (449d15c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/dxtb/_src/calculators/types/abc.py 41.66% 7 Missing ⚠️
...xtb/_src/components/interactions/solvation/alpb.py 42.85% 2 Missing and 2 partials ⚠️
src/dxtb/_src/scf/pure/iterations.py 50.00% 3 Missing ⚠️
src/dxtb/_src/calculators/config/main.py 33.33% 1 Missing and 1 partial ⚠️
src/dxtb/_src/components/classicals/halogen/hal.py 71.42% 1 Missing and 1 partial ⚠️
.../dxtb/_src/components/classicals/repulsion/base.py 60.00% 1 Missing and 1 partial ⚠️
.../dxtb/_src/components/interactions/field/efield.py 75.00% 1 Missing and 1 partial ⚠️
src/dxtb/_src/integral/base.py 84.61% 2 Missing ⚠️
src/dxtb/_src/integral/driver/pytorch/overlap.py 71.42% 1 Missing and 1 partial ⚠️
...tb/_src/calculators/properties/vibration/result.py 75.00% 1 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   82.22%   82.14%   -0.09%     
==========================================
  Files         194      194              
  Lines        9589     9628      +39     
  Branches     1436     1460      +24     
==========================================
+ Hits         7885     7909      +24     
- Misses       1352     1358       +6     
- Partials      352      361       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/dxtb/_src/components/classicals/list.py Dismissed Show dismissed Hide dismissed
src/dxtb/_src/components/classicals/list.py Dismissed Show dismissed Hide dismissed
src/dxtb/_src/components/interactions/list.py Dismissed Show dismissed Hide dismissed
test/test_a_memory_leak/test_higher_deriv.py Fixed Show fixed Hide fixed
test/test_a_memory_leak/test_repulsion.py Fixed Show fixed Hide fixed
test/test_a_memory_leak/test_scf.py Fixed Show fixed Hide fixed
test/test_a_memory_leak/test_scf.py Fixed Show fixed Hide fixed
docs/source/conf.py Dismissed Show dismissed Hide dismissed
src/dxtb/_src/integral/driver/pytorch/impls/type.py Dismissed Show dismissed Hide dismissed
@marvinfriede marvinfriede merged commit 4562481 into main Sep 16, 2024
35 checks passed
@marvinfriede marvinfriede deleted the improve-code branch September 16, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant