-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run slow tests without coverage #132
Run slow tests without coverage #132
Conversation
Also push the configuration into a config file for reproducibility.
Per suggestion from @alexmojaki at gristlabs#129 (comment) These slower tests are integration/kitchen-sink tests, so they shouldn't add substantially to the code coverage. Running them without coverage is quite a lot faster (several minutes in CI) which is well worth the small additional complexity. This commit also drops pytest outputting the junit xml file as there's not an obvious way to combine that from multiple test runs and it appears to be unused.
7ca590b
to
36fd09b
Compare
Please don't @ me in commit messages, it does weird things with github notifications |
Oh, sorry, hadn't thought about that. Yeah, I suspect it combined badly with force pushing a few times to fix CI. |
Hmmm, I feel weird about having two mechanisms for dealing with slow tests: ASTTOKENS_SLOW_TESTS and the pytest marker. |
Ah, good point. Do you think that having some of the sys.modules tests in the normal suite adds value? If not, we could just push them entirely into the slow suite and drop |
There is! We can add Concretely then I'm proposing:
|
This is somewhat redundant now that we have pytest markers for slow tests, having only a single approach to running slow tests simplifies things.
Have implemented that approach in 52e9b41. |
This looks great, thank you! |
Per suggestion from @alexmojaki at #129 (comment)
These slower tests are integration/kitchen-sink tests, so they shouldn't add substantially to the code coverage. Running them without coverage is quite a lot faster (several minutes in CI) which is well worth the small additional complexity.
This commit also drops pytest outputting the junit xml file as there's not an obvious way to combine that from multiple test runs and it appears to be unused.
This reduces the CI time from ~20 minutes to ~10 minutes, however there's a small reduction in measured coverage. Happy to address that here with unit tests if desired.
Builds on #128.
Fixes #129 as CI time is no longer quite as silly.