-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dependency on six #155
Conversation
@@ -62,7 +62,7 @@ jobs: | |||
- name: Mypy testing | |||
run: | | |||
# Not an exact mypy version, as we need 0.942 for pypy-3.8 support, but it's not available on 3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"but it's not available on 3.5" also sounds like something that can be fixed now, not necessarily here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes ... but I'm really good at managing the Debian ecosystem and releases; not so much the native Python ecosystem (pip, tox etc...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Is this ready to merge once the tests pass?
It is ready. |
For what it's worth, a much dumber patch was temporarily used in Debian: https://sources.debian.org/src/python-asttokens/2.4.1-2/debian/patches/remove-six.patch/ The good things is that the CI suite of all reverse dependencies (the one using asttokens) passed fine.
|
Thank you so much!!! |
No description provided.