Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on six #155

Merged
merged 3 commits into from
Oct 6, 2024
Merged

remove dependency on six #155

merged 3 commits into from
Oct 6, 2024

Conversation

a-detiste
Copy link
Contributor

No description provided.

@@ -62,7 +62,7 @@ jobs:
- name: Mypy testing
run: |
# Not an exact mypy version, as we need 0.942 for pypy-3.8 support, but it's not available on 3.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"but it's not available on 3.5" also sounds like something that can be fixed now, not necessarily here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ... but I'm really good at managing the Debian ecosystem and releases; not so much the native Python ecosystem (pip, tox etc...)

setup.cfg Outdated Show resolved Hide resolved
Copy link
Contributor

@alexmojaki alexmojaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Is this ready to merge once the tests pass?

@a-detiste
Copy link
Contributor Author

It is ready.

@a-detiste
Copy link
Contributor Author

For what it's worth, a much dumber patch was temporarily used in Debian: https://sources.debian.org/src/python-asttokens/2.4.1-2/debian/patches/remove-six.patch/

The good things is that the CI suite of all reverse dependencies (the one using asttokens) passed fine.

-import six
+class six:
+     PY2 = False
+     PY3 = True
+     string_types = (str,)

@alexmojaki
Copy link
Contributor

Thank you so much!!!

@alexmojaki alexmojaki merged commit 4eebd86 into gristlabs:master Oct 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants