Skip to content

Commit

Permalink
Attempts to make DropdownConditionEditor tests less flaky (#1026)
Browse files Browse the repository at this point in the history
Attempts to fix "DropdownConditionEditor in choice columns creates
dropdown conditions", and adds comments to inform future investigators.
  • Loading branch information
Spoffy authored Jun 7, 2024
1 parent c3e23ca commit caa1acd
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion test/nbrowser/DropdownConditionEditor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,13 @@ describe('DropdownConditionEditor', function () {
're\nc\n.Supervisor\n ',
]);
});
await gu.sendKeysSlowly(['hoice not in $']);
await gu.sendKeysSlowly(['hoice not in ']);
// Attempts to reduce test flakiness by delaying input of $. Not guaranteed to do anything.
await driver.sleep(100);
await gu.sendKeys('$');
await gu.waitToPass(async () => {
// This test is sometimes flaky here. It will consistently return the wrong value, usually an array of
// empty strings. The running theory is it's an issue in Ace editor.
const completions = await driver.findAll('.ace_autocomplete .ace_line', el => el.getText());
assert.deepEqual(completions, [
'$\nName\n ',
Expand Down

0 comments on commit caa1acd

Please sign in to comment.