Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCIM users endpoint #1199

Merged
merged 27 commits into from
Dec 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b47c66f
WIP
fflorent Aug 29, 2024
163ade3
SCIM: Implement egress + tests
fflorent Sep 2, 2024
642bca8
Implement ingress
fflorent Sep 3, 2024
a9f5193
Add tests
fflorent Sep 3, 2024
6db0737
SCIM: Implement DELETE
fflorent Sep 5, 2024
132bc3f
More tests and cleanups
fflorent Sep 6, 2024
a994ccd
Rebase fix + check GRIST_SCIM_USER
fflorent Sep 6, 2024
a57f042
Add GRIST_ENABLE_SCIM env variable
fflorent Sep 6, 2024
6215228
Move logic for Users to its own controller
fflorent Sep 6, 2024
44f2ee5
An unknown error should return a 500
fflorent Sep 7, 2024
5215e4f
Add a test for pagination
fflorent Sep 7, 2024
b0fe85e
Add tests for the new UsersManager methods
fflorent Sep 7, 2024
3041200
Document methods of the controller
fflorent Sep 7, 2024
efa742d
Rename ex → err in catch block
fflorent Sep 12, 2024
dc8478e
Bump Scimmy and Scimmy-Routers
fflorent Oct 18, 2024
61e8cd9
Log errors
fflorent Nov 22, 2024
ebf81a0
Only warn when the userName differ from the primary email
fflorent Nov 25, 2024
959f8b5
Rename overrideUser → overwriteUser
fflorent Nov 26, 2024
bc37751
Use full path for import
fflorent Nov 26, 2024
72cfdf0
Improve user deletion test description
fflorent Nov 26, 2024
d252f5b
Improve error message for anonymous users
fflorent Nov 26, 2024
c4f6712
Fix styling issue
fflorent Nov 26, 2024
090398c
Disallow deleting technical users
fflorent Nov 29, 2024
8312aa9
Disallow technical user modifications
fflorent Nov 29, 2024
4beef42
Update FIXME in ScimUserController
fflorent Nov 29, 2024
7ace7f8
rename "technical user" to "system user"
jordigh Nov 29, 2024
6f97aec
Document SCIM feature flag in the README
fflorent Nov 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve error message for anonymous users
Co-authored-by: jordigh <[email protected]>
fflorent and jordigh authored Nov 26, 2024
commit d252f5be513411480a46a2c7398f38e3247ab1cd
2 changes: 1 addition & 1 deletion app/server/lib/scim/v2/ScimV2Api.ts
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ const buildScimRouterv2 = (dbManager: HomeDBManager, installAdmin: InstallAdmin)
}

if (mreq.userId === dbManager.getAnonymousUserId()) {
throw new Error('Anonymous user cannot access SCIM resources');
throw new Error('Anonymous users cannot access SCIM resources');
}

return String(mreq.userId); // SCIMMYRouters requires the userId to be a string.