Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix webpack version import warning #1390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hexaltation
Copy link
Collaborator

Context

The webpack build warns about incoming changes in package.json import.

WARNING in ./stubs/app/common/version.ts 2:23-42
Should not import the named export 'version' (imported as 'packageJson') from default-exporting module (only default export is available soon)
 @ ./app/client/ui/AppHeader.ts 5:0-46 51:29-44 51:50-67 51:89-106
 @ ./app/client/ui/errorPages.ts 3:0-52 90:25-34
 @ ./app/client/errorMain.ts 2:0-57 3:28-41

webpack 5.97.1 compiled with 1 warning in 4928 ms

This PR adresses this.

Proposed solution

I follow advice in the warning to change the way we import package.json.

Has this been tested?

  • 👍 yes, locally
    Version still displays in the UI.

@hexaltation hexaltation requested a review from fflorent January 20, 2025 14:59
@hexaltation hexaltation added gouv.fr enhancement New feature or request labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gouv.fr
Projects
Status: Needs feedback
Development

Successfully merging this pull request may close these issues.

1 participant