refine the interaction between backups and main document connections #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently we changed to making backups using the main document connection, when available. The system making the backups and the system managing the document are quite loosely coupled, so the main document connection can get closed at any time. The backup process was written to expect this, but a problem appeared on the closing side: SQLite will refuse to close if a backup is in progress, and that error was entirely uncaught due to a missing await. This adds the needed await. It also adds some explicit robustness on both sides so that it is easier to tell from local considerations that shutdown should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Recently we changed backups to use the main document connection, when available, since then they can complete even while the document is changing constantly. The system making the backups and the system managing the document are quite loosely coupled, so the main document connection can get closed at any time, even during a backup. The backup process was written to expect this, but a problem appeared on the closing side: SQLite will refuse to close if a backup is in progress, and that error was entirely uncaught due to a missing await.
Proposed solution
This adds the needed await. It also adds some explicit robustness on both sides
Related issues
#1380
#1427
Has this been tested?