GROOVY-10098

groovy · May 20, 2021 · d6dfd8b · d6dfd8b
1 parent e66f8fb
commit d6dfd8b
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 0 deletions.
diff --git a/...ovy.core.tests.compiler/src/org/eclipse/jdt/groovy/core/tests/xform/TypeCheckedTests.java b/...ovy.core.tests.compiler/src/org/eclipse/jdt/groovy/core/tests/xform/TypeCheckedTests.java
@@ -2867,4 +2867,27 @@ public void testTypeChecked10091() {
             "Groovy:[Static type checking] - Incompatible generic argument types. Cannot assign groovy.lang.Closure<X> to: groovy.lang.Closure<A<java.lang.Number>>\n" +
             "----------\n");
     }
+
+    @Test
+    public void testTypeChecked10098() {
+        //@formatter:off
+        String[] sources = {
+            "C.groovy",
+            "@groovy.transform.TupleConstructor(defaults=false)\n" +
+            "class C<T extends Number> {\n" +
+            "  T p\n" +
+            "  @groovy.transform.TypeChecked\n" +
+            "  T test() {\n" +
+            "    Closure<T> x = { -> p }\n" +
+            "    x()\n" + // Cannot return value of type Object on method returning type T
+            "  }\n" +
+            "  static main(args) {\n" +
+            "    print new C<>(42).test()\n" +
+            "  }\n" +
+            "}\n",
+        };
+        //@formatter:on
+
+        runConformTest(sources, "42");
+    }
 }
diff --git a/...rg.codehaus.groovy25/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java b/...rg.codehaus.groovy25/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
@@ -3964,12 +3964,21 @@ public void visitMethodCallExpression(MethodCallExpression call) {
                         ClassNode type = getType(((ASTNode) variable));
                         if (type != null && type.equals(CLOSURE_TYPE)) {
                             GenericsType[] genericsTypes = type.getGenericsTypes();
+                            /* GRECLIPSE edit -- GROOVY-10098
                             type = OBJECT_TYPE;
                             if (genericsTypes != null) {
                                 if (!genericsTypes[0].isPlaceholder()) {
                                     type = genericsTypes[0].getType();
                                 }
                             }
+                            */
+                            if (genericsTypes != null && genericsTypes.length == 1
+                                    && genericsTypes[0].getLowerBound() == null) {
+                                type = getCombinedBoundType(genericsTypes[0]);
+                            } else {
+                                type = OBJECT_TYPE;
+                            }
+                            // GRECLIPSE end
                         }
                         if (type != null) {
                             storeType(call, type);

diff --git a/...rg.codehaus.groovy30/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java b/...rg.codehaus.groovy30/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
@@ -3674,12 +3674,21 @@ public void visitMethodCallExpression(final MethodCallExpression call) {
                         ClassNode type = getType(((ASTNode) variable));
                         if (type != null && type.equals(CLOSURE_TYPE)) {
                             GenericsType[] genericsTypes = type.getGenericsTypes();
+                            /* GRECLIPSE edit -- GROOVY-10098
                             type = OBJECT_TYPE;
                             if (genericsTypes != null) {
                                 if (!genericsTypes[0].isPlaceholder()) {
                                     type = genericsTypes[0].getType();
                                 }
                             }
+                            */
+                            if (genericsTypes != null && genericsTypes.length == 1
+                                    && genericsTypes[0].getLowerBound() == null) {
+                                type = getCombinedBoundType(genericsTypes[0]);
+                            } else {
+                                type = OBJECT_TYPE;
+                            }
+                            // GRECLIPSE end
                         }
                         if (type != null) {
                             storeType(call, type);

diff --git a/...rg.codehaus.groovy40/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java b/...rg.codehaus.groovy40/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
@@ -3587,10 +3587,19 @@ public void visitMethodCallExpression(final MethodCallExpression call) {
                         ClassNode type = getType(((ASTNode) variable));
                         if (CLOSURE_TYPE.equals(type)) {
                             GenericsType[] genericsTypes = type.getGenericsTypes();
+                            /* GRECLIPSE edit -- GROOVY-10098
                             type = OBJECT_TYPE;
                             if (genericsTypes != null && !genericsTypes[0].isPlaceholder()) {
                                 type = genericsTypes[0].getType();
                             }
+                            */
+                            if (genericsTypes != null && genericsTypes.length == 1
+                                    && genericsTypes[0].getLowerBound() == null) {
+                                type = getCombinedBoundType(genericsTypes[0]);
+                            } else {
+                                type = OBJECT_TYPE;
+                            }
+                            // GRECLIPSE end
                         }
                         if (type != null) {
                             storeType(call, type);