Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type inferencing, syntax highlighting and code navigation for extension method that overloads declared method(s) #1335

Closed
eric-milles opened this issue Jan 17, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@eric-milles
Copy link
Member

eric-milles commented Jan 17, 2022

Follow up from #1076. The situation extends beyond Object methods. Consider the following:

def map = new HashMap()
map.equals([:]) // DefaultGroovyMethods#equals(Map,Map)
map.toString() // DefaultGroovyMethods#toString(AbstractMap)
println(map) // Script#println(Object) -- not DefaultGroovyMethods#println(Object)

The runtime selection for "equals", "toString" and "println" are indicated in the comments. Highlighting for "equals" and "toString" should indicate an extension method (purple not green).

image

@eric-milles eric-milles self-assigned this Jan 17, 2022
@eric-milles eric-milles added this to the v4.5.0 milestone Jan 17, 2022
@eric-milles eric-milles changed the title Fix type inferencing, syntax highlighting and code navigation for extension method that overload declared method(s) Fix type inferencing, syntax highlighting and code navigation for extension method that overloads declared method(s) Jan 17, 2022
@eric-milles
Copy link
Member Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant