Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatter to bring in line with Eclipse Mars SR1 #142

Closed
philwebb opened this issue Oct 8, 2015 · 3 comments
Closed

Update formatter to bring in line with Eclipse Mars SR1 #142

philwebb opened this issue Oct 8, 2015 · 3 comments

Comments

@philwebb
Copy link

philwebb commented Oct 8, 2015

The patched JDT version shipped with Groovy Eclipse contains formatter bugs that have been fixed with Mars SR1. Specifically https://bugs.eclipse.org/bugs/show_bug.cgi?id=472962 is causing problems for me.

philwebb added a commit to spring-projects/spring-boot that referenced this issue Oct 9, 2015
Update Eclipse settings to make use of a custom Spring formatter
implementation. Using a custom formatter allows us to fix a couple of
issues with the version that shipped with Eclipse Mars.1 (Eclipse bugs

The custom formatter also means that it is possible to use Groovy
Eclipse despite the fact that it has formatter regressions (see
groovy/groovy-eclipse#142).

Fixes gh-4136
@guillaumecle
Copy link

I am also facing a formatter issue fixed in Mars SR1 because of groovy-eclipse.

@philwebb
Copy link
Author

philwebb commented Dec 8, 2015

@guillaumecle In the end I created a custom formatter plugin for Eclipse. You can get it here if it helps. Code is here. Once installed you get a new 'Spring' formatter in the preferences page.

@guillaumecle
Copy link

Thank you. In fact I didn't need the groovy-eclipse plugin on my eclipse installation, it came as m2e connector but wasn't necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants