No code assist on map-style constructor call for property values

[mauromol]

Consider the following:

package test16;
public class MyBean {
	private String foo;
	private String bar;
	public String getFoo() {
		return foo;
	}
	public String getBar() {
		return bar;
	}
}

And the following Groovy class:

package test16
class Test16 {
  void doSomething() {
	  def bean1 = new MyBean()
	  def bean2 = new MyBean(foo: bea|)
  }
}

Invoke code assist at "|", with the purpose of writing bean1.foo: as you can see, no proposal is shown, apart from generic proposals for class names.

[eric-milles]

There's some tension between this and #331. The argument expression is matched and flows through the catch block below. To try and provide named argument proposals, the conditional if (context.location != ContentAssistLocation.STATEMENT) was added.

    public void visitConstructorCallExpression(ConstructorCallExpression expression) {
        if (!check(expression)) {
            return;
        }

        Expression arguments = expression.getArguments();
        checkForAfterClosingParen(expression, arguments);
        ClassNode constructorType = expression.getType();

        if (check(constructorType)) {
            createContext(constructorType, blockStack.getLast(), ContentAssistLocation.CONSTRUCTOR);
        }

        try {
            // see comments in visitMethodCallExpression
            visitArguments(arguments, expression);
        } catch (VisitCompleteException e) {
            if (context.location != ContentAssistLocation.STATEMENT) {
                throw e;
            }
            // completing constructor argument (https://github.com/groovy/groovy-eclipse/issues/331)
        }

        // completion invocation offset is outside of type name and argument expressions; it is probably after opening paren or separating comma

        createContextForCallContext(expression, constructorType, constructorType.getUnresolvedName());
    }

[eric-milles]

ready to test

[mauromol]

I confirm this use case works with 3.0.0.xx-201802132346-e47, thank you! 👍