Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning for source unit with missing package statement #473

Closed
eric-milles opened this issue Feb 13, 2018 · 1 comment
Closed

No warning for source unit with missing package statement #473

eric-milles opened this issue Feb 13, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@eric-milles
Copy link
Member

eric-milles commented Feb 13, 2018

If a Java source unit is in package x according to the source folder it resides in but declares package y in its package statement, the warning The declared package "y" does not match the expected package "x" is generated. Groovy sources do not provide this warning. This is most troublesome when a new source file is created but the package statement is forgotten. No problem markers are shown but there is very unpredictable behavior finding expected types.

NOTE: This appears to be an issue only if the declared package is the default package (aka there is no package statement in the source unit).

@eric-milles eric-milles added this to the v3.0.0 milestone Feb 13, 2018
@eric-milles eric-milles changed the title No warning for source unit with missing or incorrect package statement No warning for source unit with missing package statement Feb 13, 2018
@gregg-saffell
Copy link

I think the fix for #473 may have inadvertently caused #492.

eric-milles added a commit that referenced this issue Feb 21, 2018
- improves handling for project root as output location
@eric-milles eric-milles self-assigned this Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants