Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of meminitial and memmax on comand line #648

Closed
TobiX opened this issue Jul 26, 2018 · 1 comment
Closed

Position of meminitial and memmax on comand line #648

TobiX opened this issue Jul 26, 2018 · 1 comment
Assignees
Milestone

Comments

@TobiX
Copy link

TobiX commented Jul 26, 2018

It seems groovy-eclipse-batch since 2.4.13-02 doesn't like the extra option for meminitial (-J-Xms) and memmax (-J-Xmx) after the arguments file anymore. You get this error:

Failure executing groovy-eclipse compiler:
File -J-Xmx2048m is missing

The simplest fix seems to me to move this block of code

if (isNotBlank(config.getMaxmem())) {
cli.addArguments(new String[] {"-J-Xmx" + config.getMaxmem()});
}
if (isNotBlank(config.getMeminitial())) {
cli.addArguments(new String[] {"-J-Xms" + config.getMeminitial()});
}

some lines up before the argument file, right?

@eric-milles
Copy link
Member

Yes, Oxygen and Photon insert the @file arguments inline with the @ arg. Not sure if/when this changed.

I should be able to patch using your suggestion and deploy groovy-eclipse-compiler:3.0.0-01 sometime today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants