Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error range indicators are off on line 1 and do not include '@' for annotations #881

Closed
eric-milles opened this issue May 8, 2019 · 1 comment
Closed

Error range indicators are off on line 1 and do not include '@' for annotations #881

eric-milles opened this issue May 8, 2019 · 1 comment
Assignees
@eric-milles
Labels
bug
Milestone
v3.4.0

Comments

@eric-milles
Copy link
Member

eric-milles commented May 8, 2019 •
edited
Loading

Error squiggles in the Groovy editor on line 1 of a source file are shifted right by one position. And squiggles for annotations do not include the @ as they do in the Java editor.
@eric-milles eric-milles self-assigned this May 8, 2019
@eric-milles eric-milles added the bug label May 8, 2019
@eric-milles eric-milles added this to the v3.4.0 milestone May 8, 2019
eric-milles added a commit that referenced this issue May 8, 2019
@eric-milles
Fix for #881: off-by-one error in GroovyCompilationUnitDeclaration
0cfb6ee 
- start offset/line,column of AnnotationNode includes @
- end offset/line,column of AnnotationNode matches type
@eric-milles
Copy link
Member Author

image

eric-milles added a commit that referenced this issue May 9, 2019
@eric-milles
Refactor error reporting and source positioning of AnnotationNode
90045ed 
- node gets full range
- type gets name range

#881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eric-milles eric-milles

Labels
bug
Projects
None yet
Milestone
v3.4.0
Development

No branches or pull requests
1 participant
@eric-milles