Add Parallel::find and Parallel::find_result #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addtion to Parallel::Kill and Parallel::Break, a new Exception class named Parallel::Return allows raising an Exception which wraps a result value. That wrapped result will be unwrapped. When a method expects a single result, the option `:return_one` must be provided, because a given Enumeration might not contain a matching element or result.
grosser
reviewed
Oct 12, 2020
| else | ||
| work_in_processes(job_factory, options.merge(:count => size), &block) | ||
| end | ||
| work_direct(job_factory, options, &block) |
grosser
reviewed
Oct 12, 2020
| @@ -485,7 +524,8 @@ def process_incoming_jobs(read, write, job_factory, options, &block) | |||
| end | |||
|
|
|||
| def handle_exception(exception, results) | |||
| return nil if [Parallel::Break, Parallel::Kill].include? exception.class | |||
| return if [Parallel::Break, Parallel::Kill].include?(exception.class) | |||
| return exception if exception.class == Parallel::Return | |||
There was a problem hiding this comment.
I'd expect this to return the value ?
Suggested change
| return exception if exception.class == Parallel::Return | |
| return exception.result if exception.class == Parallel::Return |
grosser
reviewed
Oct 12, 2020
Comment on lines
306
to
316
| if results | ||
| options[:return_results] ? results : source | ||
| if options[:return_one] | ||
| if results.is_a?(Return) | ||
| results.return_value | ||
| end | ||
| elsif options[:return_results] | ||
| results | ||
| else | ||
| source | ||
| end | ||
| end |
There was a problem hiding this comment.
this looks like it's doing similar kind of logic to handle_exception ... can it be combined ?
grosser
reviewed
Oct 12, 2020
Comment on lines
+239
to
+256
| def find_result(array, options = {}, &block) | ||
| raise "You must provide a block when calling #first_result" if block.nil? | ||
| map(array, options.merge({return_one: true})) do |*a| | ||
| if result = block.call(*a) | ||
| raise Parallel::Return.new(result) | ||
| end | ||
| end | ||
| end | ||
|
|
||
| def find(array, options = {}, &block) | ||
| raise "You must provide a block when calling #find" if block.nil? | ||
| map(array, options.merge({return_one: true})) do |*a| | ||
| if block.call(*a) | ||
| raise Parallel::Return.new(*a) | ||
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
maybe let's just do the raise Return part first, so this is a smaller PR ?
grosser
reviewed
Oct 12, 2020
| @@ -14,6 +14,14 @@ class Break < StandardError | |||
| class Kill < StandardError | |||
| end | |||
|
|
|||
| class Return < StandardError | |||
| attr_reader :return_value | |||
There was a problem hiding this comment.
Suggested change
| attr_reader :return_value | |
| attr_reader :value |
|
Logic looks right, but I think you stumbled into a problem area of the code there, I think we should do a cleanup first before adding a new feature, the handle_exception and results/source logic seems like they would go together |
|
Thanks for the review. I will take the time to apply some changes soon. |
|
v1.20 has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of ticket #273.