-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modulemap for system sqlite #1
Conversation
Package.swift
Outdated
import PackageDescription | ||
|
||
let package = Package( | ||
name: "SQLiteSDK", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package.swift
Outdated
let package = Package( | ||
name: "SQLiteSDK", | ||
providers: [ | ||
.Apt("libsqlite3-dev") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of sheer curiosity: which version of SQLite is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually needed only on Linux (for apt-get). It prints a hint if sqlite is not installed.
3.8.2 on Ubuntu 14.04
3.11.0 on 16.04
I don't know which version is preinstalled on OS X.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I understand - I guess that the -dev
suffix just means that it comes with sqlite3.h
.
The question of the version that comes preinstalled on macOS/iOS is important in GRDB, because some features are protected with @available attributes. But I'm sure SPM supports them correctly.
For Linux, we'll need to talk about the SQLite version with more details. But we're not there yet :-)
I think it's ready now, isn't it, @zmeyc ? |
@groue Yes, I've updated the PR. |
💯 @zmeyc, thanks! |
No description provided.