Spot a few Demeter law violations

groue · Aug 6, 2018 · 78a6f72 · 78a6f72
1 parent b307e90
commit 78a6f72
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/GRDB/Core/RowAdapter.swift b/GRDB/Core/RowAdapter.swift
@@ -493,12 +493,12 @@ struct AdaptedRowImpl : RowImpl {
 
     func hasNull(atUncheckedIndex index: Int) -> Bool {
         let mappedIndex = mapping.baseColumnIndex(atMappingIndex: index)
-        return base.impl.hasNull(atUncheckedIndex: mappedIndex)
+        return base.impl.hasNull(atUncheckedIndex: mappedIndex) // base.impl: Demeter violation
     }
 
     func databaseValue(atUncheckedIndex index: Int) -> DatabaseValue {
         let mappedIndex = mapping.baseColumnIndex(atMappingIndex: index)
-        return base.impl.databaseValue(atUncheckedIndex: mappedIndex)
+        return base.impl.databaseValue(atUncheckedIndex: mappedIndex) // base.impl: Demeter violation
     }
 
     func fastDecode<Value: DatabaseValueConvertible & StatementColumnConvertible>(
@@ -507,7 +507,7 @@ struct AdaptedRowImpl : RowImpl {
         debugInfo: @autoclosure () -> ValueConversionDebuggingInfo) throws -> Value
     {
         let mappedIndex = mapping.baseColumnIndex(atMappingIndex: index)
-        return try base.impl.fastDecode(Value.self, atUncheckedIndex: mappedIndex, debugInfo: debugInfo)
+        return try base.impl.fastDecode(Value.self, atUncheckedIndex: mappedIndex, debugInfo: debugInfo) // base.impl: Demeter violation
     }
 
     func fastDecodeIfPresent<Value: DatabaseValueConvertible & StatementColumnConvertible>(
@@ -516,15 +516,15 @@ struct AdaptedRowImpl : RowImpl {
         debugInfo: @autoclosure () -> ValueConversionDebuggingInfo) throws -> Value?
     {
         let mappedIndex = mapping.baseColumnIndex(atMappingIndex: index)
-        return try base.impl.fastDecodeIfPresent(Value.self, atUncheckedIndex: mappedIndex, debugInfo: debugInfo)
+        return try base.impl.fastDecodeIfPresent(Value.self, atUncheckedIndex: mappedIndex, debugInfo: debugInfo) // base.impl: Demeter violation
     }
 
     func dataNoCopy(
         atUncheckedIndex index:Int,
         debugInfo: @autoclosure () -> ValueConversionDebuggingInfo) throws -> Data?
     {
         let mappedIndex = mapping.baseColumnIndex(atMappingIndex: index)
-        return try base.impl.dataNoCopy(atUncheckedIndex: mappedIndex, debugInfo: debugInfo)
+        return try base.impl.dataNoCopy(atUncheckedIndex: mappedIndex, debugInfo: debugInfo) // base.impl: Demeter violation
     }
 
     func columnName(atUncheckedIndex index: Int) -> String {