Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatabaseMigrator should wipe database when migrations are renamed #725

Closed
groue opened this issue Mar 9, 2020 · 1 comment
Closed

DatabaseMigrator should wipe database when migrations are renamed #725

groue opened this issue Mar 9, 2020 · 1 comment
Labels
enhancement

Comments

@groue
Copy link
Owner

groue commented Mar 9, 2020 •
edited
Loading

When the flag eraseDatabaseOnSchemaChange is set, a DatabaseMigrator should erase the database if migrations change names.

Today, we can get an error:

  1. Register migration "foo" which creates table "theTable"
  2. Rename migration "foo" to "bar"
  3. Migrate -> SQLite error 1: table "theTable" already exists.

cc @pakko972
groue added a commit that referenced this issue Mar 18, 2020
@groue
Address #725
c1d1797
@groue
Copy link
Owner Author

groue commented Mar 21, 2020

Shipped in v4.12.0!

@groue groue closed this as completed Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@groue