GRDB 7: Async database accesses honor Task cancellation #1610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GRDB 6, asynchronous database accesses such as
try await read { ... }
ortry await write { ... }
complete even if the wrapper Task is cancelled.In GRDB 7, asynchronous database accesses respect Task cancellation. If a Task is cancelled, reads and writes throw a
CancellationError
, pending transactions are rolled back, and the database is not modified. The only SQL statement that can execute in a cancelled database access isROLLBACK
.The effect of this change on your application depends on how it uses tasks. For example, take care of database jobs initiated frop the
task
SwiftUI modifier.If you want an asynchronous database access to always complete, regardless of Task cancellation, wrap it in an unstructured Task:
Other asynchronous database accesses, such as methods accepting a completion blocks (
asyncRead
, etc.), Combine publishers, RxSwift observables, do not handle cancellation and will proceed to completion by default.