Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate extended result codes, and expose result codes as Swift constants #180

Merged
merged 23 commits into from
Mar 2, 2017
Merged

Activate extended result codes, and expose result codes as Swift constants #180

merged 23 commits into from
Mar 2, 2017

Conversation

groue
Copy link
Owner

@groue groue commented Mar 1, 2017 •
edited
Loading

This PR addresses #171 by @hartbit.

  • it activates extended result codes, so that SQLite reports more precise errors.
  • it introduces a new type ResultCode which has constants for all SQLite-declared result codes, so that the end user can access those result codes by name without importing the low-level C SQLite module.
  • it modifies DatabaseError so that its former code: Int32 property is replaced with two new properties: resultCode and extendedResultCode, which both let the user handle errors at the desired level of precision.

Documentation

Remaining TODOs:

  • add a fixit for migrating away from obsolete code property
  • check the availability of sqlite3_extended_result_codes

groue and others added 16 commits February 26, 2017 15:36
@groue
#171: introduce ResultCode
7eb592d
@groue
#171: always use extended result codes
f0d1f23
@groue
#171: rename ResultCode.code into ResultCode.resultCode (@hartbit's s…
e4a3469 
…uggestion)
@groue
Add Request.fetchCount(). Implements #176 (comment)
2d2c596
@groue
Keep Request.fetchCount() simple (#176 (comment))
42ebffc
@groue
Tests for Request.fetchCount() (#176 (comment))
8a46869
@groue
#171: Apply @hartbit's suggestion of having two DatabaseError propert…
fc18b15 
…ies: resultCode and extendedResultCode
@groue
#171: CHANGELOG
8dadf42
@groue
Typo
4866ba0
@groue
Better CHANGELOG
b0bf8e8
@groue
#171: Documentation
1908f1b
@groue
#171: ~= ResultCode operator
5bcfb7f
@groue
#171: ResultCode tests
b1ea970
@groue
Merge branch 'master' into Issue171
846604c
@groue
#171: Preserve some extended result code that were lost
b873162
@groue
#171: Missing upgrades to the new ResultCode APIs
fe05ac9
@groue groue mentioned this pull request Mar 1, 2017
Closed
@groue groue merged commit 39a0b56 into master Mar 2, 2017
@groue
Copy link
Owner Author

groue commented Mar 2, 2017

@hartbit, this has shipped in v0.102.0.

@groue groue deleted the Issue171 branch March 2, 2017 12:43
groue added a commit that referenced this pull request Mar 26, 2017
@groue
Document that extended result codes are not always available (#171, #180
dedfd5c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@groue