Introduce request derivation protocols #329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the four protocols SelectionRequest, FilteredRequest, AggregatingRequest, and OrderedRequest, which provide basic request derivation API. QueryInterfaceRequest adopts those protocols:
This PR is a step towards the Associations API, where QueryInterfaceRequest will no longer be the only type that provides the
select
andfilter
methods:Also in this PR:
request.select(sql: "...")
does no longer selects aSQLExpressionLiteral
, but aSQLSelectionLiteral
instead (a new, internal type). The newSQLExpressionLiteral
will raise a fatal error when GRDB wants to know the number of selected columns, instead of lettingSQLExpressionLiteral
return an ill-advised 1. This fix will make handling of joined requests, where counting columns is important, more robust.