Expressions are no longer PATs #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groue
added a commit
that referenced
this pull request
Apr 22, 2018
groue
added a commit
that referenced
this pull request
Apr 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQLSelectable and SQLExpression protocols that fuel the query interface have turned into PATs (protocol with associated type) in GRDB 2.9.
This has introduced inconvenience for some users, would could no longer easily introduce custom expression types (such as a typed Column type, for @freak4pc - as notified in a private Twitter conversation).
This PR reverts this change: SQLSelectable and SQLExpression are no longer PATs.