Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the
request.reversed()
method do nothing unless an ordering was already applied:In previous versions,
reversed()
would sort by descending rowId (inspiration drawn from ActiveRecord). Unfortunately, this made-up ordering is not guaranteed to be the exact opposite of the default SQLite ordering. And associations will soon need a stricter model of what "reversing" a request means.So let's go back to basics:
Reversing an undefined order gives another undefined order.