Refactor PersistenceError.recordNotFound #486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GRDB 3 PersistenceError was defined as below:
With such a definition, one can only build PersistenceError.recordNotFound with a fully defined record instance. It is impossible to throw this error with partial information. But some apps need that.
This PR changes the definition of PersistenceError to:
When you catch this error, you get the table and the primary key of the unfound record: