Fix eager loading of HasManyThrough associations #533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes some bugs with eager loading of HasManyThrough associations.
The bugs may occur when two conditions are met:
For example, given this schema:
Using both
Player.team
andPlayer.competitions
is a single request may lead to unexpected or inconsistent behaviors.A sample request which was not behaving correctly:
After this PR is merged, buggyRequest will fatalError, complaining that the association key "team" is used in incompatible ways. Future GRDB versions may handle it, but GRDB 4.0 does not.
One possible fix is to include the competitions from the team:
Another way to mix
Player.team
andPlayer.competitions
in a single request is to make sure both teams (the one fromPlayer.team
, and the one hidden insidePlayer.competitions
) use different association keys. For example: