-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FAQ to clarify "Wrong number of statement arguments" error with "like '%?%'" #538
Conversation
Add "? as a parameter" in the "Good to Know" section to explain how to build like pattern like '%?%'.
- Rewrite the paragraph as an FAQ - Explicitly mention the error "Wrong number of statement arguments" and give an example causing such issue. - Improve the wording and add a link to the SQLite documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @Timac, this is much better 👍
Please change the target branch of the pull request to development
, and address the few concerns below. We'll shortly merge your FAQ :-)
…with the query interface. Then provide the second approach using the || operator.
Hey @groue , I did the changes as requested. I also change the FAQ to provide both solutions:
I think that having these different examples might help future readers. Let me know if you need any other changes. Thanks again for providing such a great framework! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requested changes have been implemented.
…ause choices are complicated
OK, @Timac, I slightly modified the copy, removed the mention of the query interface which is not the topic here, and removed the second solution because one solution is all that people are looking for here. Also, merged the development branch in, and updated the change log. Thank you very, very much 👍 |
By the way, welcome to the GRDB contributors! 🤝 Just drop me a line if you'd like to be granted with a push access to the repository. |
@groue Happy to have helped! |
Add an FAQ about the SQLite error 21 "wrong number of statement arguments" with LIKE queries. The documentation contains an example of a LIKE query exhibiting the issue as well as explanation about the problem and a workaround.
See related issue:
#530