Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typo fix #560

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Minor typo fix #560

merged 1 commit into from
Jun 26, 2019

Conversation

bellebethcooper
Copy link
Collaborator

Just a minor typo fix in documentation.

Pull Request Checklist

  • This pull request is submitted against the development branch.
  • Inline documentation has been updated.
  • README.md or another dedicated guide has been updated.
  • Changes are tested.

@groue
Copy link
Owner

groue commented Jun 26, 2019

Hey, thank you very much @bellebethcooper 👍

Did I already invite you as a collaborator to the repo, so that you have push access? If not, and if you are interested, just drop me a line.

@groue groue merged commit 5345ccd into groue:development Jun 26, 2019
@bellebethcooper
Copy link
Collaborator Author

No problem! Nice to be able to help in small ways :) I don't think I have push access, no. If you're happy to do that, it'd make these little edits quicker :)

Thanks as always for your work on GRDB! I'm using it right now for a new app using SwiftUI and Combine, and I've just discovered GRDBCombine which I'm excited to start looking at.

@groue
Copy link
Owner

groue commented Jun 26, 2019

It'll be a pleasure to count you in! 💯

And thanks for giving GRDBCombine a try, that's really cool! It's very young, but it should work: please open an issue if anything looks weird. Also, I don't have any professional use for it right now, so I could not really check its ability at fulfilling our daily needs: feel free to comment on any pain point you could meet as well :-) Much of it is inspired from RxGRDB - some missing context or information may be available there.

@bellebethcooper
Copy link
Collaborator Author

Perfect, thanks! I've been exclusively using PromiseKit so anything reactive outside promises is all new to me. I've been leaning heavily on RxSwift docs to get my head around it all, so I'll definitely read up on RxGRDB as well :)

@groue
Copy link
Owner

groue commented Jun 26, 2019

Looks like a smart move. I'm happy I've been introduced to RxSwift before Combine was shipped. It's much easier to grok it after a little practice has lifted the darkest shadows.

@bellebethcooper
Copy link
Collaborator Author

I believe that! I'm glad I started with PromiseKit, as I found that hard to wrap my head around at first, but it's been a good base for picking up Combine.

@groue
Copy link
Owner

groue commented Jun 26, 2019

Fun times :-)

@groue groue added this to the GRDB 4.2.0 milestone Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants