-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Swift static library integration via CocoaPods #570
Conversation
Hi @chrisballinger, This looks like a much useful PR. I'll look at it when I'm back from vacations, in about a week. Thank you very much for the investigation job which is behind 👍 |
Thanks, no rush, enjoy your vacation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chrisballinger,
Your PR works like a charm 💯
However, README#CocoaPods has not been updated. Please update it so that users know that both technique are supported.
Also, changes were not tested. Would you please allow me to push to your branch? I want to make sure both installation methods are tested on Travis (framework, and static). I have a commit ready, but I lack the permission to push. There should be a checkbox somewhere on the pull request page that allows you to do that (allow push from repository maintainers, something like that).
Suggestion:
|
Oh, and also please merge or rebase the latest development branch, and add your PR to the CHANGELOG: 570 goes right between 563 and 574. That'll nicely complete the PR :-) |
@groue Thanks for taking a look! You should be able to push to that branch now. I'll try to put the finishing touches on this PR tomorrow. |
Push done! I hope Travis will swallow the new tests in the first stroke :-) |
adb66e7
to
d357f48
Compare
8a80c22
to
bdf802a
Compare
@groue Rebased and added an entry to README and CHANGELOG |
Thank you @chrisballinger, welcome to the GRDB contributors! I'd be happy to grant you push access to the repository. Drop me a line if you are interested! |
Pull Request Checklist
development
branch.This PR resolves issue #360 which prevented using GRDB when integrated as a Swift static library via CocoaPods. It removes the custom modulemap and allows CocoaPods to generate the umbrella header with
grdb_config.h
. I successfully tested both the standard and SQLCipher subspecs against these changes.If you'd like I could also remove the
use_frameworks!
line from theREADME
as it would be no longer required if this were merged.Cheers!