Expose table name and full-text filtering methods to DerivableRequest #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quest to DerivableRequest requirements
… new support for full-text search
…required join chaining
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR appends the TableRequest protocol to the requirements of the DerivableRequest protocol.
This enhances the expressivity of DerivableRequest and associations:
Constrained extensions to DerivableRequest can now use
filter(key:),filter(keys:),orderByPrimaryKey(), etcAssociations and constrained extensions to DerivableRequest can now use the full-text methods
matching(_:).The inspiration for this change comes from https://github.com/openbitapp/GRDB.swift. Thank you @robcas3!
Strictly speaking, this PR introduces breaking changes to both the experimental protocols Association and DerivableRequest:
Association now requires that its origin and destination associated types conform to the TableRecord protocol.
DerivableRequest now requires TableRequest conformance.
Those breaking changes should be harmess: it is highly unlikely any GRDB user defines custom types based on those protocols.