-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic region tracking for ValueObservation #586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new very simple way to define a ValueObservation 😍
For example:
The old method
tracking(_:fetch:)
is still present, but is now presented as an optimized version which can help reduce write contention when you use a DatabasePool and the fetch is slow:There are two new internal features behind this pull request:
Observations are now able to automatically infer their tracked region from the executed fetch request(s):
The database region tracked by an observation is able to change as time passes and observed values are refreshed.
This allows to perform conditionals (if, guard, switch) during the fetch.
For example, the observation below tracks only the team database table, or both the team and player tables, depending on the presence or absence of the tracked team as time passes and database gets modified: