Add the ability to execute multiple SQL statements at once

[peter-ss]

Added support for multiple-statement execution via a new API: Database.executeMultiStatement().

Adjusted unit tests accordingly. Removed unit test for catching error when a multi-statement SQL string is handed to db.execute(), since the code halts with a message to the dev in that case, instead of throwing an error.

I’d be happy to update any documentation with examples of use, if you’d like.

[groue]

I'm no longer on vacation ;-)

Removed unit test for catching error when a multi-statement SQL string is handed to db.execute(), since the code halts with a message to the dev in that case, instead of throwing an error.

I don't get it: executeMultiStatement() throws, and it's good to test that the thrown error contains all the precious debugging information!

Besides this tiny nitpicking, I can already accept your PR right away.

I would still:

• Extract UpdateStatement.Changes into DatabaseChanges,
• Update README.md and RELEASE_NOTES.md

If you still feel inspired, go ahead. I can take it over if you prefer. You've already done a great job.

[peter-ss]

Working on these right now...

On Mon, Aug 17, 2015 at 11:16 AM, Gwendal Roué [email protected]
wrote:

I'm no longer in vacation ;-)

Removed unit test for catching error when a multi-statement SQL string is
handed to db.execute(), since the code halts with a message to the dev in
that case, instead of throwing an error.

I don't get it: executeMultiStatement() throws, and it's good to test that
the thrown error contains all the precious debugging information!

Besides this tiny nitpicking, I can already accept your PR right away.

I would still:

• Extract UpdateStatement.Changes into DatabaseChanges,
• Update README.md and RELEASE_NOTES.md

If you still feel inspired, go ahead. I can take it over if you prefer.
You've already done a great job.

—
Reply to this email directly or view it on GitHub
#6 (comment).

[peter-ss]

OK - I made some of your suggested updates. Didn't update RELEASE_NOTES
because I couldn't find it. The PR is updated.

On Mon, Aug 17, 2015 at 11:16 AM, Gwendal Roué [email protected]
wrote:

I'm no longer in vacation ;-)

Removed unit test for catching error when a multi-statement SQL string is
handed to db.execute(), since the code halts with a message to the dev in
that case, instead of throwing an error.

I don't get it: executeMultiStatement() throws, and it's good to test that
the thrown error contains all the precious debugging information!

Besides this tiny nitpicking, I can already accept your PR right away.

I would still:

• Extract UpdateStatement.Changes into DatabaseChanges,
• Update README.md and RELEASE_NOTES.md

If you still feel inspired, go ahead. I can take it over if you prefer.
You've already done a great job.

—
Reply to this email directly or view it on GitHub
#6 (comment).

[groue]

Gorgeous, @peter-ss :-) Thanks a lot!

Do you want write access to the repository?

[groue]

Version 0.8.0 has just shipped with your contribution.

[peter-ss]

Excellent. I'm glad that I was able to contribute.

On Mon, Aug 17, 2015 at 11:25 PM, Gwendal Roué [email protected]
wrote:

Version 0.8.0 has just shipped with your contribution.

—
Reply to this email directly or view it on GitHub
#6 (comment).

[groue]

Hello @peter-ss. GRDB v0.37.0 has just shipped, and it has merged your Database.executeMultiStatement() contribution into Database.execute(). You can even feed your multiple statements with arguments, now:

try db.execute(
    "INSERT INTO persons (name) VALUES (?);" +
    "INSERT INTO persons (name) VALUES (?);" +
    "INSERT INTO persons (name) VALUES (?);",
    arguments; ['Harry', 'Ron', 'Hermione'])