Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tvOS #600

Merged
merged 3 commits into from
Aug 24, 2019
Merged

Add support for tvOS #600

merged 3 commits into from
Aug 24, 2019

Conversation

kdubb
Copy link
Contributor

@kdubb kdubb commented Aug 22, 2019

Xcode Project

  • tvOS Target
  • tvOS Unit Test Target
  • tvOS Scheme

Makefile

  • tvOS Target Min/Max
  • tvOS Actions (copies iOS)

CI

  • tvOS Travis stages

Packaging

  • CocoaPods - Podfile Updated
  • SwiftPM - Not Changes Required

Documentation

  • Readme Updated

Pull Request Checklist

  • This pull request is submitted against the development branch.
  • Inline documentation has been updated.
  • README.md or another dedicated guide has been updated.
  • Changes are tested.

## Xcode Project
- [x] tvOS Target
- [x] tvOS Unit Test Target
- [x] tvOS Scheme

## Makefile
- [x] tvOS Target Min/Max
- [x] tvOS Actions (copies iOS)

## CI
- [x] tvOS Travis stages

## Packaging
- [x] CocoaPods - Podfile Updated
- [x] ~SwiftPM - Not Changes Required~

## Documentation
- [x] Readme Updated
@groue
Copy link
Owner

groue commented Aug 23, 2019

Hello @kdubb,

Thanks for this pull request of high quality! It looks like it should be merged in shortly.

One Travis check has failed, though. When I run make test_framework_GRDBtvOS_minTarget with Xcode 10.2.1 on my machine, I get the following output:

xctest (82461) encountered an error (Failed to load the test bundle. (Underlying error: The bundle “GRDBtvOSTests” couldn’t be loaded because it is damaged or missing necessary resources. The bundle is damaged or missing necessary resources.

Are we sure tvOS 9.0 is testable?

kdubb added 2 commits August 23, 2019 10:54
tvOS 9.0 appears to have issues with running tests
@kdubb
Copy link
Contributor Author

kdubb commented Aug 23, 2019

@groue Truth be told I didn't run it against tvOS 9.0 locally; I was relying on Travis to test permutations.

I cannot get tvOS 9.0 to run either so I bumped the minimum to 10.0

@groue groue merged commit 7cf10bf into groue:development Aug 24, 2019
@groue
Copy link
Owner

groue commented Aug 24, 2019

That's what Travis is for :-)

Thank you very much @kdubb. Hey, this is your second merged pull request here, after #160. Would you like a push access to the repository? Just drop me a line, and I'll invite you.

@groue
Copy link
Owner

groue commented Aug 28, 2019

Shipped in v4.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants