Add support for SQLite Pre-Update Hooks (+ tests) #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If SQLITE_ENABLE_PREUPDATE_HOOK is defined, and GRDB is built with a custom SQLite library with the functionality (see: GRDBCustomSQLite), enable support for SQLite Pre-Update Hooks and the new `willChangeWithEvent` callback on TransactionObservers.
|
This is a blessed day 💝, that's awesome! Tests ran smoothly after following SQLiteCustom/README.md instructions. You're a xcconfig wizard! Git ignores the -USER files, and this is an opportunity for regressions because a simple git clone stops testing for pre-update hooks. A thing to remember. Still, thanks a lot, you're a boon! Now let's write some documentation and we'll have a gorgeous release!! |
| @@ -1381,7 +1381,21 @@ extension Database { | |||
| savepointStack.clear() | |||
| for observer in transactionObservers.flatMap({ $0.observer }) { | |||
| for event in eventsBuffer { | |||
| observer.databaseDidChangeWithEvent(event) | |||
| if let event = event as? DatabaseEvent { | |||
There was a problem hiding this comment.
I'll refactor those runtime checks.
groue
added a commit
that referenced
this pull request
Jun 3, 2016
groue
added a commit
that referenced
this pull request
Jun 3, 2016
…ransactionObserver method so that we avoid runtime checks on events type
|
Refactoring done |
|
This PR has shipped in v0.71.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If SQLITE_ENABLE_PREUPDATE_HOOK is defined, and GRDB is built with a custom SQLite library with the functionality (see: GRDBCustomSQLite), enable support for SQLite Pre-Update Hooks and the new
willChangeWithEventcallback on TransactionObservers.willChangeWithEventprovides a DatabasePreUpdateEvent, which contains the same information as DatabaseUpdateEvent, plus:As mentioned in the comments, the requirements are:
SQLite 3.13.0+, built with SQLITE_ENABLE_PREUPDATE_HOOK (which can be accomplished using GRDBCustomSQLite).