Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor conflict resolution for batch updates #647

Merged
merged 5 commits into from
Nov 10, 2019
Merged

Honor conflict resolution for batch updates #647

merged 5 commits into from
Nov 10, 2019

Conversation

groue
Copy link
Owner

@groue groue commented Nov 10, 2019

During the development of batch updates (#646), conflict resolution has been forgotten. This pull request fixes this omission!

// UPDATE OR IGNORE player SET ...
try Player.updateAll(db, onConflict: .ignore, /* assignments... */)

// Uses Player.persistenceConflictPolicy.conflictResolutionForUpdate
try Player.updateAll(db, /* assignments... */)

@groue groue added the bug label Nov 10, 2019
@groue groue merged commit 51a1c41 into development Nov 10, 2019
@groue groue deleted the dev/batch-update-policy branch November 10, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@groue