-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database Lock Prevention #660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes it possible to prevent acquisition of locks on a database.
It aims at providing the necessary ground-level work for the prevention of
0xdead10cc
exception in iOS apps that store their database in the container on an App Group.https://developer.apple.com/library/archive/technotes/tn2151/_index.html:
We can thus prevent the
0xdead10cc
exception if we can release and prevent locks between the notification that the additional background execution time is about to expire, and the end of the suspended state.In this pull request, we only address the exclusive lock prevention itself, not its scheduling.
Those methods are public because they are defined on the DatabaseReader protocol. But they are not supposed to be used by the GRDB user. They won't be documented in the main README. They will be used by a future pull request which will target
0xdead10cc
specifically.Between
startPreventingLock()
andstopPreventingLock()
, all database accesses may throw a DatabaseError of codeSQLITE_INTERRUPT
, orSQLITE_ABORT
, except reads in WAL mode.Update
The followup pull request #668 has changed the vocabulary used in this PR. We know talk about "suspended" databases, and the start/stop methods have been renamed, and made internal.