Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken substr return in replacements.php #65

Closed

Conversation

JungleGenius
Copy link

@JungleGenius JungleGenius commented Dec 25, 2024

Hi Adrian Happy Holidays,

Here is a pull request to fix the currently broken the {substr.{replacement}} code.

Also I think you should rethink the replacement caching because I had to hack my theme's functions.php with the following just to to deal with stale replacement values:

function disable_replacements_cache_for_form_page() { wp_cache_set( 'last_changed', microtime(), 'groundhogg/replacements' ); }

add_action( 'groundhogg/replacements/init', 'disable_replacements_cache_for_form_page');

Admittedly I was using {substr.{replacement}} on {GET.url_param} I don't think my use case is too unique.

Hopefully this can get merged into the main branch soon so I don't have to use a hacked plugin for too long in production.

Also as you don't have a public repo for the groundhogg contracts plugin I'm posting a screen shot of the edit required to fix the print button to work. It look like JQuery was not getting loaded so I added the wp_enqueue_script for it.

groundhogg-contracts-jquery-signing-bug

I hope you can get this added to your non-public repo. Thank for the great product.

-Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants