fix: export type for registerEndpoints #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbushong
requested changes
Feb 25, 2022
lib/typedefs.d.ts
Outdated
Comment on lines
36
to
37
| registerEndpoint(name: string, endpointFn: EndpointFn): void; | ||
| registerEndpoints(endpoints: { [name: string]: EndpointFn }): void; |
There was a problem hiding this comment.
issue: These should return this
lib/typedefs.d.ts
Outdated
Comment on lines
16
to
18
| | ((cb?: any) => FetchResponse) | ||
| | { | ||
| [key: string]: (options: any, cb?: any) => FetchResponse; |
There was a problem hiding this comment.
suggestion: The arguments to the actual methods don't necessarily include (or start with) a callback, so I'd probably make this (...args: any[]) or some such
JimLiu
force-pushed
the
type-register
branch
from
0f719b1 to
79e4cf4
Compare
JimLiu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.