-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish through Github Packages #87
Conversation
Signed-off-by: Stephen Bunn <[email protected]>
Would this impact publishing to https://www.npmjs.com/package/@groveco/backbone.store in any way? |
From their documentation Thanks for pointing out the Circle CI job though. The question I still have is "do we still want to publish |
Signed-off-by: Stephen Bunn <[email protected]>
478b89a
Signed-off-by: Stephen Bunn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updated readme. Did you ever find out how many third party packages are using Backbone.store through npm besides Grove?
Based on details from NPM, we have 0 dependents published within NPM. |
Signed-off-by: Stephen Bunn <[email protected]>
As part of us starting to serve packages through Github packages, we need the scope
@groveco
to be served by a single NPM registry. Currently, we publish@groveco/backbone.store
through the npmjs.org registry. We should start publishing this package through our Github organization's package registry.The following changes add a basic
publishConfig
to thepackage.json
that indicates where this package should be published to. Publishing this package depends on you having the appropriate.npmrc
configuration setup (see https://github.com/groveco/skylight#usage for info).Following the approval and merge of this package, we need to actually publish the current version of
backbone.store
to Github packages:npm publish
the current version@groveco/grove
As this package is still published to NPM (v0.4.2), we should not be breaking any existing build pipelines.
Currently blocked by the following items:
NPM_GITHUB_REGISTRY_ACCESS_TOKEN
defined in this project's CircleCI environment so we can publish to GitHub Packages using the same job. https://groveco.atlassian.net/servicedesk/customer/portal/6/DSD-1671?created=true