Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish through Github Packages #87

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Conversation

stephen-bunn
Copy link
Contributor

@stephen-bunn stephen-bunn commented Nov 2, 2021

As part of us starting to serve packages through Github packages, we need the scope @groveco to be served by a single NPM registry. Currently, we publish @groveco/backbone.store through the npmjs.org registry. We should start publishing this package through our Github organization's package registry.

The following changes add a basic publishConfig to the package.json that indicates where this package should be published to. Publishing this package depends on you having the appropriate .npmrc configuration setup (see https://github.com/groveco/skylight#usage for info).

Following the approval and merge of this package, we need to actually publish the current version of backbone.store to Github packages:

  1. Tag and release the current version (0.5.1)
  2. npm publish the current version
  3. Update the dependency in @groveco/grove

As this package is still published to NPM (v0.4.2), we should not be breaking any existing build pipelines.


Currently blocked by the following items:

@jessewagstaff
Copy link
Contributor

Would this impact publishing to https://www.npmjs.com/package/@groveco/backbone.store in any way?
It currently happens within the CircleCI config which callsnpm publish --access public

@stephen-bunn
Copy link
Contributor Author

Would this impact publishing to npmjs.com/package/@groveco/backbone.store in any way? It currently happens within the CircleCI config which callsnpm publish --access public

From their documentation --access public only affects visibility within the registry (not the registry itself). My assumption is that this command will still publish the package but to the given publishConfig.registry.

Thanks for pointing out the Circle CI job though.
If we want to automate publishing to the Github Packages registry, we will also need to update the config they write in that job.

The question I still have is "do we still want to publish @groveco/backbone.store to NPM". IMO I would prefer that we just start publishing our internal packages through an internal registry. I know we've open-sourced this library in NPM... but we don't really maintain and improve on it.

peltzergrove
peltzergrove previously approved these changes Nov 3, 2021
jessewagstaff
jessewagstaff previously approved these changes Nov 3, 2021
Copy link
Contributor

@jessewagstaff jessewagstaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated readme. Did you ever find out how many third party packages are using Backbone.store through npm besides Grove?

@stephen-bunn
Copy link
Contributor Author

Thanks for the updated readme. Did you ever find out how many third party packages are using Backbone.store through npm besides Grove?

Based on details from NPM, we have 0 dependents published within NPM.
This doesn't mean people cannot install @groveco/backbone.store and have it within their dependencies. For that reason, we are not removing the package from NPM. Instead, we are just archiving the project at the current version.

@stephen-bunn
Copy link
Contributor Author

I've noticed that we are tagging versions incorrectly in this repo.
I'm planning on just doing a v1 release here as well from the latest working tag to avoid future confusion.
image

@stephen-bunn stephen-bunn merged commit c60347b into master Nov 10, 2021
@stephen-bunn stephen-bunn deleted the publish-github-packages branch November 10, 2021 23:02
stephen-bunn added a commit that referenced this pull request Nov 11, 2021
Signed-off-by: Stephen Bunn <[email protected]>
@stephen-bunn stephen-bunn mentioned this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants