feat(components): add searchbar and refactor input #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects: @gio-design/components, website
affects: @gio-design/components
affects: @gio-design/components, website
affects: @gio-design/components
affects: @gio-design/components, website, icon
affects: @gio-design/components
affects: @gio-design/components, @gio-design/icon, @gio-design/themes, @gio-design/tokens, website
affects: website
# Conflicts: # packages/website/src/components/basic/toast/index.zh-CN.md
# Conflicts: # packages/components/src/index.ts
affects: @gio-design/components, @gio-design/icons, website
affects: @gio-design/components
affects: @gio-design/components
affects: @gio-design/components
# Conflicts: # packages/icons/src/index.tsx
added 2 commits
August 24, 2020 19:36
affects: @gio-design/components, @gio-design/icons, @gio-design/tokens, website
|
Deploy preview for gio-design failed. |
added 2 commits
August 25, 2020 12:45
affects: @gio-design/components, @gio-design/icons
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 65.78% 70.68% +4.89%
==========================================
Files 78 77 -1
Lines 2040 1968 -72
Branches 542 514 -28
==========================================
+ Hits 1342 1391 +49
+ Misses 693 572 -121
Partials 5 5
Continue to review full report at Codecov.
|
|
Deploy preview for ready! ✅ https://deploy-preview-153--gio-design.surge.sh |
affects: @gio-design/components, @gio-design/icons, @gio-design/tokens, website
|
Deploy preview for gio-design failed. |
affects: @gio-design/components, @gio-design/tokens, website
|
Deploy preview for ready! ✅ https://deploy-preview-153--gio-design.surge.sh |
1eeing
changed the title
1eeing
changed the title
jack0pan
requested changes
Sep 1, 2020
|
|
||
| export { InputNumber, InputHidden, Password, TextArea }; | ||
| export { InputProps } from './types'; | ||
| export { InputNumber, Password, TextArea }; | ||
|
|
||
| export default class extends React.Component<InputProps> { |
There was a problem hiding this comment.
这个定义还是放在 Input 里吧，这样 index.tsx 只用来 import 和 export，这样 index.tsx 不需要单测覆盖。
added 2 commits
September 1, 2020 19:23
|
Deploy preview for ready! ✅ https://deploy-preview-153--gio-design.surge.sh |
|
Deploy preview for ready! ✅ https://deploy-preview-153--gio-design.surge.sh |
|
Deploy preview for ready! ✅ https://deploy-preview-153--gio-design.surge.sh |
jack0pan
approved these changes
Sep 8, 2020
|
Deploy preview for ready! ✅ https://deploy-preview-153--gio-design.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.