Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): support branch step in StepModal #192

Merged
merged 5 commits into from
Sep 10, 2020
Merged

feat(components): support branch step in StepModal #192

merged 5 commits into from
Sep 10, 2020

Conversation

phyzess
Copy link
Contributor

@phyzess phyzess commented Sep 7, 2020

affects: @gio-design/components, website

Related issue link

Changelog

Language Changelog
🇺🇸 English Support branch step in StepModal.
🇨🇳 Chinese StepModal 组件支持分支路径。

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-192--gio-design.surge.sh

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #192 into master will increase coverage by 6.75%.
The diff coverage is 84.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   70.68%   77.43%   +6.75%     
==========================================
  Files          77       80       +3     
  Lines        1968     2052      +84     
  Branches      514      532      +18     
==========================================
+ Hits         1391     1589     +198     
+ Misses        572      458     -114     
  Partials        5        5              
Impacted Files Coverage Δ
packages/components/src/components/alert/alert.tsx 0.00% <0.00%> (ø)
...es/components/src/components/checkbox/checkbox.tsx 100.00% <ø> (ø)
...es/components/src/components/tooltip/placements.ts 90.47% <ø> (ø)
packages/components/src/components/tree/Tree.tsx 0.00% <0.00%> (ø)
...ckages/components/src/components/tree/iconUtil.tsx 0.00% <0.00%> (ø)
...s/components/src/utils/hooks/useDebounceLoading.ts 100.00% <ø> (ø)
packages/components/src/utils/hooks/useRefs.tsx 100.00% <ø> (ø)
packages/components/src/utils/hooks/useToggle.ts 0.00% <0.00%> (ø)
...s/src/components/table/hook/useEllipsisTooltip.tsx 57.14% <35.71%> (-1.95%) ⬇️
...omponents/src/components/breadcrumb/Breadcrumb.tsx 96.49% <50.00%> (ø)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea6a690...34e25bb. Read the comment docs.

@LEEHONCN LEEHONCN self-requested a review September 7, 2020 10:09
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-192--gio-design.surge.sh

1 similar comment
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-192--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

2 similar comments
@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@phyzess phyzess linked an issue Sep 10, 2020 that may be closed by this pull request
affects: @gio-design/components, website
affects: @gio-design/components
affects: @gio-design/components, website
affects: @gio-design/components
affects: @gio-design/components
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-192--gio-design.surge.sh

@1eeing 1eeing merged commit eb69c6f into growingio:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modal组件补测试
4 participants