Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal #207

Merged
merged 2 commits into from
Sep 12, 2020
Merged

Modal #207

merged 2 commits into from
Sep 12, 2020

Conversation

phyzess
Copy link
Contributor

@phyzess phyzess commented Sep 11, 2020

Related issue link

#206

Changelog

Language Changelog
🇺🇸 English fix footer bug in Modal; fix reset bug of StepModal.
🇨🇳 Chinese 修复 Modal footer设置无效问题;修复 StepModal steps 变更 stepStack 未重置问题

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

affects: @gio-design/components
affects: @gio-design/components
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #207 into master will increase coverage by 2.54%.
The diff coverage is 82.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   67.44%   69.98%   +2.54%     
==========================================
  Files          89       89              
  Lines        2356     2369      +13     
  Branches      602      604       +2     
==========================================
+ Hits         1589     1658      +69     
+ Misses        762      707      -55     
+ Partials        5        4       -1     
Impacted Files Coverage Δ
...components/src/components/upload/UploadContext.tsx 100.00% <ø> (ø)
...ges/components/src/components/upload/xhrRequest.ts 4.00% <ø> (ø)
...ckages/components/src/components/upload/Upload.tsx 60.00% <56.25%> (+0.38%) ⬆️
packages/components/src/components/upload/utils.ts 17.50% <60.00%> (-0.23%) ⬇️
...omponents/src/components/breadcrumb/Breadcrumb.tsx 98.27% <75.00%> (+1.78%) ⬆️
packages/components/src/components/radio/Group.tsx 92.00% <75.00%> (+0.16%) ⬆️
...kages/components/src/components/upload/Preview.tsx 28.12% <75.00%> (ø)
...nents/src/components/breadcrumb/BreadcrumbItem.tsx 100.00% <100.00%> (+7.14%) ⬆️
.../src/components/breadcrumb/BreadcrumbSeparator.tsx 100.00% <100.00%> (ø)
packages/components/src/components/menu/Menu.tsx 100.00% <100.00%> (+100.00%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53708d9...e650a70. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-207--gio-design.surge.sh

@LEEHONCN LEEHONCN merged commit f7e44ae into growingio:master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants