Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avatar): fix avatar can't trigger Dropdown #208

Merged
merged 1 commit into from
Sep 15, 2020
Merged

fix(avatar): fix avatar can't trigger Dropdown #208

merged 1 commit into from
Sep 15, 2020

Conversation

LEEHONCN
Copy link
Contributor

@LEEHONCN LEEHONCN commented Sep 12, 2020

affects: @gio-design/components

修复avatar组件不能被Dropdown等组件触发的bug。
所有需要触发tooltip、Popconfirm、Popover、Dropdown的组件都需要解构参数,并传rest给return的元素。

Related issue link

Changelog

Language Changelog
🇺🇸 English fix avatar can't trigger Dropdown
🇨🇳 Chinese 修复avatar组件不能触发Dropdown 的bug

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

affects: @gio-design/components
@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #208 into master will increase coverage by 0.08%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   69.98%   70.07%   +0.08%     
==========================================
  Files          89       90       +1     
  Lines        2369     2379      +10     
  Branches      604      606       +2     
==========================================
+ Hits         1658     1667       +9     
- Misses        707      708       +1     
  Partials        4        4              
Impacted Files Coverage Δ
packages/components/src/utils/composeRef.ts 85.71% <85.71%> (ø)
...ckages/components/src/components/avatar/Avatar.tsx 97.77% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d60fa...0bbbcfe. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-208--gio-design.surge.sh

@phyzess phyzess requested review from zzt1224 September 15, 2020 02:50
@LEEHONCN LEEHONCN merged commit 3df51b5 into growingio:master Sep 15, 2020
@LEEHONCN LEEHONCN deleted the avatar-add branch November 4, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants